Fix cache invalidation bug for Forge key scope updates #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix cache key format mismatch in invalidate_forge_scope_cache() - Ensure cache invalidation uses same key format as cache setting - Add comprehensive unit tests for cache invalidation behavior Fixes TensorBlock#8
- Fix cache key format mismatch in invalidate_forge_scope_cache() - Apply same fix to async version - Add comprehensive unit tests with 7 test cases - Follow project code style guidelines Fixes TensorBlock#8
Contributor
|
Looks good to me. Cloned to my local and validate that it's working correctly. Good work 👍 |
Contributor
|
Thanks for the contribution — it's a solid fix. Especially appreciate catching the bug where the cache key was missing the "forge-" prefix. This issue originated from [this line]( Line 161 in c2030af |
wilsonccccc
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes issue #8 where newly added providers were not immediately reflected in Forge key permissions. Users had to wait for the 5-minute cache expiry before seeing updated provider lists.
Root Cause
Cache key format mismatch between cache setting and invalidation operations:
forge_scope:abc123forge_scope:forge-abc123This resulted in cache invalidation calls targeting non-existent cache entries.
Solution
invalidate_forge_scope_cache()and async variantAll the tests I ran passed, let me know if there are issues still.
Fixes #8